Page MenuHome
Differential D3997

Node Resizing Hit Area
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Nov 27 2018, 5:32 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBce40b0b3f527: UI: fix too wide resize area on edges of nodes, interfering with content.
rBSce40b0b3f527: UI: fix too wide resize area on edges of nodes, interfering with content.
Summary

When you move your mouse to the sides of a node the cursor changes into a "move" cursor and you can drag the edge left or right.

Unfortunately, that area is too wide and is only within the node contents area. The following image illustrates the current area on the left:

In a nutshell it starts in the middle of the border and extends into the content by 10 units. The biggest problem with this is that it will sometimes keep some content from working correctly if that area and the sizing area overlap. An example is the left side of the ColorRamp, which you cannot move.

The attached patch alters this so that the hit area is centered over the border, so works from the same distance on the left or right of the border. Specifically it makes it work from 3 units to the left to 3 units to the right, so still 6 units wide in total. The result is (roughly) illustrated by the right side of the attached image

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Dec 7 2018, 1:46 AM

Dragging from just outside the node shows the cursor but starts a box select.

source/blender/editors/space_node/drawnode.c
273

This should be multiplied with UI_DPI_FAC. It was wrong already, but 3px is quite small on a retina screen.

source/blender/editors/space_node/node_draw.c
1166 ↗(On Diff #12681)

Shouldn't this be 3px like above?

Probably to be shared with a single #define.

This revision now requires changes to proceed.Dec 7 2018, 1:46 AM
Harley Acheson (harley) updated this revision to Diff 12796.Dec 7 2018, 3:35 AM

Actually the new left-click drag wrecks my idea of having the drag area start outside of the node. Which is fine since I love the new left click stuff.

This patch then just defines a NODE_RESIZE_MARGIN in node_intern.h so it can be easily changed.

The drag still only works within the node bounds, not outside of it. But it is scaled correctly and is about half as wide as it was before. Therefore it does not interfere with node contents.

So with ColorRamp you can, once again, grab the handles when they are at either end of the ramp. But resizing is still easy to do, no matter what the zoom level.

This revision is now accepted and ready to land.Jan 4 2019, 3:16 PM
Closed by commit rBce40b0b3f527: UI: fix too wide resize area on edges of nodes, interfering with content. (authored by Harley Acheson (harley), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 4 2019, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13112

View Options

source/blender/editors/space_node/drawnode.c

Loading...
View Options

source/blender/editors/space_node/node_intern.h

Loading...