Page MenuHome

Active Curves UI point should stand out
Needs ReviewPublic

Authored by swann (slumber) on Tue, Nov 27, 11:58 PM.

Details

Summary

A proposal for T58090.

Diff Detail

Repository
rB Blender

Event Timeline

swann (slumber) edited the summary of this revision. (Show Details)
swann (slumber) edited the summary of this revision. (Show Details)Wed, Nov 28, 12:03 AM
swann (slumber) edited the summary of this revision. (Show Details)Wed, Nov 28, 10:09 AM

great, though this makes the active point dark, and not so clearly visible.

Could we use the selected vertex color, for example? Or do we just solve this in the theme?

@Pablo Vazquez (pablovazquez) : thoughts?

Thanks for the feedback !
I am making it use the selected vertex color.
I will post an update soon !

swann (slumber) updated this revision to Diff 12705.EditedThu, Nov 29, 12:36 PM
  • Added a new function to retrieve theme color (scaled to 0.0-1.0 range) given a space type and a color id.
  • Setup curve and color ramp active item to use the vertex_select theme color.

Fantastic. Looks good to me.

@Pablo Vazquez (pablovazquez) Can you check if this is ok?

Agree with changing the Cureve map. However, the Color Ramp colors should remain neutral here as the handles are colored to reflect the actual color of the stop,

Ah nice! Looks good to me too.

BTW that function comes in very handy!

So the last version is using TH_TEXT, and TH_VERTEX_SELECT when a vertex is active? Why not VERTEX and VERTEX_SELECT?

@Pablo Vazquez (pablovazquez) I have been testing with TH_VERTEX witch is black in the default theme:

so I suggest to left the TH_TEXT color for a better visibility of inactive curve points.
I could change to TH_VERTEX or another theme color if you prefer.