Fix T58068: gizmo crash for bone on a disabled armature layer
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 28 2018, 2:40 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Maniphest Tasks

Commits

I'm not very familiar with the widget code, but I think it's the poll function that is wrong.

It should use bPoseChannel *pchan = BKE_pose_channel_active(ob); and then pchan->bone, rather than arm->act_bone.

In general the way data is retrieved in poll functions should match the other functions.

This revision now requires changes to proceed.Nov 28 2018, 3:01 PM

yep, into the poll

This revision is now accepted and ready to land.Nov 29 2018, 2:12 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			source/blender/editors/space_view3d/view3d_gizmo_armature.c (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12694	6d2e2e3		Nov 28 2018, 2:40 PM	★	★
Diff 2	12699	f24147d	yep, into the poll	Nov 29 2018, 10:49 AM	★	★
Diff 3	12706	28d2058	rB3cc0eb36c3c05ac2661e2fac04c51db1bf0082b9	Nov 29 2018, 2:28 PM	★	★