Page MenuHome

Implement bvhtree.fromObject
AbandonedPublic

Authored by Dalai Felinto (dfelinto) on Tue, Dec 4, 11:48 PM.

Details

Summary

I am not sure if we want users to pass depsgraph, or scene.
Also, mesh_create_eval_final_view and mesh_create_eval_final_render are pretty much the same,
so mesh_create_eval_no_deform and mesh_create_eval_no_deform_render are as well.

Issue reported on: T58734

Diff Detail

Repository
rB Blender
Branch
temp-depsgraph-bvh (branched from blender2.8)
Build Status
Buildable 2583
Build 2583: arc lint + arc unit

Event Timeline

I am not sure if we want users to pass depsgraph, or scene.

You can't pass a scene, it does not fully define state of object you want to use for the BVH. So it's either depsgraph or (scene, view layer, frame, evaluation mode). Think depsgraph is more clear, and also matches other similar areas like render API.

Passing only depsgraph is fine AFAICS,

Committed on 80ffd7b4597.