Page MenuHome

Fix unused fb slot problem of some bugged AMD GPUs
ClosedPublic

Authored by Germano Cavalcante (mano-wii) on Wed, Dec 5, 6:55 PM.

Details

Summary

The function describes everything.
On some bugged AMD GPUs, if there is an empty color slot between the color slots, all textures after this slot are apparently skipped/discarded.

A user already reported a similar issue on an AMD forum: https://community.amd.com/thread/200786

Diff Detail

Repository
rB Blender

Event Timeline

Clément Foucault (fclem) requested changes to this revision.Wed, Dec 5, 10:53 PM

After fixing the integer underflow it does not crash here.

source/blender/gpu/intern/gpu_framebuffer.c
433

GPUAttachmentType is unsigned (at least here on linux) so it cannot go negative and just provoke integer underflow.

This revision now requires changes to proceed.Wed, Dec 5, 10:53 PM
  • fix integer underflow;
This revision is now accepted and ready to land.Wed, Dec 5, 11:30 PM
This revision was automatically updated to reflect the committed changes.