Details

Reviewers

Group Reviewers

Commits

rBSad47b0236e32: GP: Refactor coordinates to float
rBad47b0236e32: GP: Refactor coordinates to float
rB1b1b28f4bd36: GP: Refactor coordinates to float

Summary

See: D4030

Diff Detail

Repository: rB Blender

Event Timeline

Charlie Jolly (charlie) created this revision.Dec 5 2018, 7:48 PM

This patch changes the point storage to floats. The changes are limited to GP only. Not touched ED_ or BLI_ functions. This does mean that there are quite a few casts but from my limited testing I've not had any issues so far.

@Antonio Vazquez (antoniov) If you could take a look that would be appreciated. I won't be around until tomorrow to follow up.

Antonio Vazquez (antoniov) added inline comments.Dec 5 2018, 8:30 PM

source/blender/editors/gpencil/gpencil_paint.c
1365	Colud you calc mval_i outside of the loop?
1389	Same as above (calc outside loop)

The changes look good in general, only review that you calc the integer conversion only once and try to use only one variable definition. Really, this is not an issue running the code, but makes it more clear.

source/blender/editors/gpencil/annotate_paint.c
813	Maybe you could calc mval_i at the begining of the function.

Antonio Vazquez (antoniov) requested changes to this revision.Dec 5 2018, 8:36 PM

This revision now requires changes to proceed.Dec 5 2018, 8:36 PM

Fix GPU format and address comments

Git issue, lost some changes

@Charlie Jolly (charlie) Commit in 2.8 and then merge to greasepencil-object to keep the branch updated to last version.

This revision is now accepted and ready to land.Dec 7 2018, 8:24 AM

Fixed issue with cursor, was customdata cast as int

Closed by commit rBad47b0236e32: GP: Refactor coordinates to float (authored by Charlie Jolly (charlie)). · Explain WhyDec 7 2018, 12:46 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			source/blender/editors/gpencil/annotate_draw.c (12 lines)
M			source/blender/editors/gpencil/annotate_paint.c (60 lines)
M			source/blender/editors/gpencil/drawgpencil.c (18 lines)
M			source/blender/editors/gpencil/gpencil_brush.c (12 lines)
M			source/blender/editors/gpencil/gpencil_fill.c (12 lines)
M			source/blender/editors/gpencil/gpencil_intern.h (9 lines)
M			source/blender/editors/gpencil/gpencil_paint.c (111 lines)
M			source/blender/editors/gpencil/gpencil_primitive.c (18 lines)
M			source/blender/editors/gpencil/gpencil_select.c (4 lines)
M			source/blender/editors/gpencil/gpencil_utils.c (60 lines)
M			source/blender/editors/include/ED_gpencil.h (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12772	9b228e4		Dec 5 2018, 7:48 PM	★	★
Diff 2	12787	50d26e7	Fix GPU format and address comments	Dec 6 2018, 4:22 PM	★	★
Diff 3	12788	50d26e7	Git issue, lost some changes	Dec 6 2018, 4:32 PM	★	★
Diff 4	12803	32aefb6	Fixed issue with cursor, was customdata cast as int	Dec 7 2018, 12:20 PM	★	★
Diff 5	12806	942e983	rBad47b0236e32dc9a583a0d7209d8030bbb7c358e	Dec 7 2018, 12:45 PM	★	★

GP: Refactor coordinates to float
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12806

source/blender/editors/gpencil/annotate_draw.c

source/blender/editors/gpencil/annotate_paint.c

source/blender/editors/gpencil/drawgpencil.c

source/blender/editors/gpencil/gpencil_brush.c

source/blender/editors/gpencil/gpencil_fill.c

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_paint.c

source/blender/editors/gpencil/gpencil_primitive.c

source/blender/editors/gpencil/gpencil_select.c

source/blender/editors/gpencil/gpencil_utils.c

source/blender/editors/include/ED_gpencil.h

GP: Refactor coordinates to floatClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12806

source/blender/editors/gpencil/annotate_draw.c

source/blender/editors/gpencil/annotate_paint.c

source/blender/editors/gpencil/drawgpencil.c

source/blender/editors/gpencil/gpencil_brush.c

source/blender/editors/gpencil/gpencil_fill.c

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_paint.c

source/blender/editors/gpencil/gpencil_primitive.c

source/blender/editors/gpencil/gpencil_select.c

source/blender/editors/gpencil/gpencil_utils.c

source/blender/editors/include/ED_gpencil.h

GP: Refactor coordinates to float
ClosedPublic
Actions

Revision Contents
Changeset List