Page MenuHome

Fix T57816: Crash when deleting recently orphaned collection

Authored by Dalai Felinto (dfelinto) on Dec 18 2018, 11:37 PM.

Diff Detail

rB Blender

Event Timeline

@Brecht Van Lommel (brecht) the issue here was that when collection_missing_parents_remove() is called, collection_find_child() is still valid for the about to be deleted collection and its children.
Thus we would never get to remove the CollectionParent from the children.

With this patch we make sure the parent is set to NULL upon remove (in library_query), so we can clear it from its children.

I set @Bastien Montagne (mont29) as subscriber here as well in case he has anything to add re: library query.

This revision is now accepted and ready to land.Dec 19 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.