Page MenuHome

Fix FPS meter not showing in VSE
ClosedPublic

Authored by Richard Antalik (ISS) on Dec 20 2018, 11:03 PM.

Details

Summary

typo?

Also why is ED_scene_draw_fps in view3d_draw_legacy.c? Asking, because I haven't looked into new openGL lib - is it because of drawing code, or just nobody looked at it in general?

Bug report: T59644

Diff Detail

Event Timeline

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Dec 20 2018, 11:05 PM

The FPS drawing code should probably be a better place, it's just there for legacy reasons.

Fix looks good.

This revision is now accepted and ready to land.Dec 20 2018, 11:10 PM

@Brecht Van Lommel (brecht) So Now can I commit this, or is there something else to be done?

Yes, you can commit approved patches. For the commit message, see guidelines here:
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

Richard Antalik (ISS) closed this revision.EditedDec 22 2018, 1:45 AM

Yes, you can commit approved patches. For the commit message, see guidelines here:
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

https://developer.blender.org/rBa451d4abbc1c9e1158338da3806f30ae0d15fd7b

Sorry there is some dirt in this commit,
Tried to get help on IRC, as my git-fu is weak. Said, this should be OK

Edit: Looks like it is correct that commit is applied to submodules...

@Richard Antalik (ISS), it's not a big issue. Just next time be careful to only commit changes to intended files.

I'm not sure if this is a separate bug, but the FPS text is outside the viewport when there are no strips.


this is with e4dbfe0a98c1


@Richard Antalik (ISS) I'm in the initial stages of migrating to 2.8x, do you want me to start submitting reports for bugs, issues..?
I ask as I'm not sure what you are tackling, outside of your progress on devtalk.blender.org and already reported issues, or what you plan to commit to 2.80 before it's final release.

I'm not sure if this is a separate bug, but the FPS text is outside the viewport when there are no strips.


this is with e4dbfe0a98c1


@Richard Antalik (ISS) I'm in the initial stages of migrating to 2.8x, do you want me to start submitting reports for bugs, issues..?
I ask as I'm not sure what you are tackling, outside of your progress on devtalk.blender.org and already reported issues, or what you plan to commit to 2.80 before it's final release.

Thanks, I did not catch this.
Please submit all bugs you will find.

@Richard Antalik (ISS), it's not a big issue. Just next time be careful to only commit changes to intended files.

It was only one file, but commit was applied to subprojects - all commits look like this so I assume it's OK.

@Richard Antalik (ISS), the problem is that we are somewhat misusing git submodules, with make update always updating them to the latest revision. But this update is not supposed to be committed every time, it's too noisy in the commit logs.

So to avoid committing the submodule hashes, you can add specific files or directories to your commit. For example git commit source/blender would have worked in this case.