Page MenuHome

cleanup: remove unused passes
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Dec 21 2018, 11:53 PM.

Details

Summary
  • use_pass_indirect, use_pass_specular from ViewLayer RNA (should be safe?)
  • RGBA, DIFFUSE, SPEC, REFLECT, REFRACT, INDIRECT from all over (not sure, especially DNA handling and the freestyle case...)

Diff Detail

Repository
rB Blender

Event Timeline

Pretty unsafe territory for me, but had a go (and removed a little more) following:

also noticed we still have use_pass_indirect and use_pass_specular hanging around, could/should this be removed from ViewLayer RNA?

Yes, these can be removed.

Mostly fine, just one thing to fix.

source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
450–451

This should only check RE_PASSNAME_DIFFUSE_COLOR.

Now it will end up using whichever of the 3 was last in the passes list.

This revision is now accepted and ready to land.Thu, Dec 27, 2:42 PM
This revision was automatically updated to reflect the committed changes.