Ported ANT Landscape addon to blender 2.80 as well as its presets
Thanks for the changes.
Generally looks good to me, except for the small things I pointed out inline.
Also, I have not tried the addon yet, so I don't know if it really works. I expect that you tested it.
Style should be name: PropertyType() (no space between the name and colon). Same for all the other property definitions.
Looks like this list of enum property items is used in multiple places. I think you should define this list in one place and then use it multiple times to reduce code duplication.
Make classes a tuple instead of a list (it should not change later on).
I'm only reading this on my phone right now and can't see the whole file.
Use for cls in reversed(classes). This might not be strictly necessary but might help in cases when there are dependencies between the classes.
Why are thos lines not needed anymore?
Made the changes. Will be submitting an update shortly.
And yes, I tested the add-on with its different settings and it appears to be working similar to 2.79
Yes panel_func_add_landscape is a class. Changed it to match the rest of the classes' naming convention.
In these lines it appears like previously cellnoise was assigned the value 14. In the 2.8, since we're using "CELLNOISE" directly, we don't need this switching of values. Removed
put the reversed traversal in the unregister, instead of the register.
Jacques, I'm probably missing the nuance behind the reverse traversal of the class tuple. Can you describe what potential problem it avoids?
In most cases, it has no practical importance/effect. However, in some rare cases, there can be dependencies, and order of register operations is important. In that case, unregistering in reversed order is mandatory too, or some operations may fail (like trying to remove a property from an already unregistered class, etc.). This should actually be the case of the whole unregister func, it should always do everything in reversed order compared to register one, for sake of consistency and sanity. ;)
Ah OK, that’s because this is not a regular git diff, git apply removes by default the first item in paths. You need to do git apply -p0 path/to/D4122.diff and it works like a charm. :)