Page MenuHome

Outliner: better support for clips/masks ('Blender File' view)

Authored by Philipp Oeser (lichtwerk) on Dec 30 2018, 12:11 AM.


  • clips/masks were not showing an icon [both dont have a dedicated icon,

took the ones used elsewhere]

  • masks hit an assert in outliner_add_element()
  • missing outliner update when adding a mask

spotted while looking into T59939

Diff Detail

rB Blender

Event Timeline

Besides note below (for which I’d be happy to have other devs’s feelings), patch LGTM.


Not sure that this is really wrong, but it feels a bit odd to add notifier in a helper func… Usually they are supposed to be defined by operators's code itself…


For consistency better to put it in the operator code I think.

review by brecht, mont29: moved notifier (closer) to operator
in case of adding mask primitives this is still in a utility function, but other notifiers are, too... (can be seen right there)

This revision is now accepted and ready to land.Jan 4 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.