Page MenuHome

Volumetric influence control for lights
Needs ReviewPublic

Authored by Alexander Court (spiegelball) on Jan 3 2019, 2:56 PM.

Details

Diff Detail

Repository
rB Blender
Branch
vol-fac (branched from master)
Build Status
Buildable 7360
Build 7360: arc lint + arc unit

Event Timeline

Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 8:05 PM

I'm thinking this option is more likely to be useful as a ray visibility option like for cycles.
I'm not really keen on adding more EEVEE specific option that makes is farther from cycles.

However I do see the use case of this feature so I'm on the fence.

The patch itself is good.

source/blender/draw/engines/eevee/shaders/volumetric_scatter_frag.glsl
47

Apply clang format.

48

Use an epsilon here. 1e-8 should do it.

This revision now requires changes to proceed.Mar 23 2020, 8:05 PM
  • Correct versioning code.
  • Merge branch 'master' into vol-fac
  • Fix versioning code and light type name.
  • Merge branch 'master' into vol-fac
  • Implement code review notes.