Page MenuHome

Pie Menu Tap Unstick Timeout
ClosedPublic

Authored by Justin Jones (jjones780) on Jan 8 2019, 8:50 AM.

Details

Summary

Fix to behaviour of Pie menus where they don't release unless the mouse is moved first.

I believe this fits with the intended behavior:

Setting the tap timeout to 20 (default) or so will cause short taps (<20ms) to stick the pie menu open and anything longer to close the menu on key release.
Setting it to 1000 will make it act like it is now where a very long hold ( <10s) will still result in the pie menu sticking open.
Setting it to 0 will cause the pie menu to close no matter how short the key was tapped.

Re:
https://devtalk.blender.org/t/pie-menu-disable-on-release-key-patch/2237/27
https://developer.blender.org/T56949

Diff Detail

Repository
rB Blender

Event Timeline

I should've removed the
/* distance from initial point */
line just above my changes in source/blender/editors/interface/interface_handlers.c
That comment looks like it was left over from earlier code?

Brecht Van Lommel (brecht) updated this revision to Diff 13155.

This patch had spaces everywhere instead of tabs, and so did not apply for me. Not sure how that could have happened.

I'll commit with some tweaks.

This revision is now accepted and ready to land.Jan 10 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.