Page MenuHome

[Starting Point] Bool Tool Patch for 2.8 (Draw Poly Brush and updateHandle not yet implemented)
ClosedPublic

Authored by Simon Appelt (derappelt) on Jan 10 2019, 8:58 PM.

Details

Summary

Bool Tool Patch for 2.8
Missing Features:

  • Draw Poly Brush (I don't found a replacement for use_gpencil_continuous_drawing)
  • HandleScene update Handler (Objects no longer contain is_updated)

Diff Detail

Event Timeline

Hi Simon, your patch does not port all add-on functionality and since there is nothing about that in the description of the task, here is what currently missing:

  1. Replacement for scene_update_post handler was not implemented, which means modifier stack of the canvas object would not be cleaned up if user removes the brush object.
  2. Draw Poly Brush tool has not been ported.

Sorry I've updated the description.
The commit is more meant to be a starting point.
Since the Grease Pencil changed quite drastically, I think a complete rewrite of that part is required.
I din't know how to update the scene handler since it got removed. I found the "depsgraph_update_post", but not yet found a solution to detect wich part of the graph changed. Could need support here.

Simon Appelt (derappelt) retitled this revision from Bool Tool Patch for 2.8 to [Starting Point] Bool Tool Patch for 2.8 (Draw Poly Brush and updateHandle not yet implemented).Jan 12 2019, 12:48 PM
Mikhail Rachinskiy (alm) requested changes to this revision.Jan 15 2019, 9:15 AM

OK, then let's make it tidy:

  • Remove scene_update_post handler including HandleScene and GCollector functions, it doesn't do anything useful anyway and just duplicates functionality of Remove Brush and Remove All operators.
  • Set TODO comment for Draw Poly Brush.
  • Cleanup unused imports: handlers, EnumProperty.
  • bl_info сleanup:
    • Remove wiki_url entry, the page no longer exist.
    • Change location entry from View3D > Toolshelf to View3D > Sidebar.
This revision now requires changes to proceed.Jan 15 2019, 9:15 AM
  • Removed scene_update_post, HandleScene and GCollector
  • Added TODO comment for Draw Poly Brush
  • Removed unused imports: handlers, EnumProperty
  • bl_info:
    • Removed wiki_url entry
    • Changed location entry from View3D > Toolshelf to View3D > Sidebar
This revision is now accepted and ready to land.Jan 16 2019, 9:32 AM