Page MenuHome

UI Paper Cut: light icon constant in properties sidebar
ClosedPublic

Authored by Joep Peters (Joep) on Jan 22 2019, 12:54 PM.

Details

Summary

Small UI fix to keep the 'Light' icon the same in the properties sidebar.

It no longer changes depending on the 'Light' type and now uses the ICON_OUTLINER_DATA_LIGHT icon.

Diff Detail

Repository
rB Blender

Event Timeline

Joep Peters (Joep) edited the summary of this revision. (Show Details)Jan 22 2019, 12:58 PM

Yay! This was a papercut for a while. @Brecht Van Lommel (brecht) if you are okay with this could we get it in?

I approve of the design change. It makes it easier to identify the Light Properties, and is more consistent with the rest of the Properties tabs.

However, this doesn't seem to be the correct way to do it technically. Rather than setting each Light type to use the same icon, we should just set the Light Properties tab to simply use ICON_OUTLINER_DATA_LIGHT in the same way we do for all other Properties tabs.

@William Reynish (billreynish) Thank you for your comment. I was looking for the files regarding the panels initially; Which file(s) defines the property tab behavior?

Hm, I also could not find this while searching around. @Brecht Van Lommel (brecht): Do you know where to set this?

Search for sbuts->dataicon. This will need a special exception rather than use the RNA struct icon.

Light probes behave similar to lights, so I guess would also need to be changed.

Joep Peters (Joep) added a comment.EditedJan 22 2019, 2:54 PM

@Brecht Van Lommel (brecht) I've updated the diff. Is this the correct way of implementing it?

I also had a quick look on adding the exception for the light probes which could be done in the same way. I wasn't sure which icon to use though. What is the ID of the lightprobe icon in the 'add object' menu? (see screen) Maybe that one is a good fit?

Yes exactly. That’s the generic icon for light probes.

It seems we have no "thin" lightprobe data icon, only the "thick" light probe object icon.

I'll just commit the patch as is then, if an icon gets added it's trivial to use it.

This revision is now accepted and ready to land.Jan 22 2019, 3:36 PM

@Brecht Van Lommel (brecht) Awesome, thank you!

I'll keep an eye on the addition of a "thin" light probe data icon in order to fix the same issue regarding the probes.

Who is in charge of the UI icons? Would love to fix the lightprobe UI Paper Cut as well :)!

I don't really understand this thing about thin icons? IFAIK we already have a generic icon for light probes, which is the one you identified.

We have different icons for objects and object data.

  • ICON_OUTLINER_OB_LIGHT
  • ICON_OUTLINER_DATA_LIGHT
  • ICON_OUTLINER_OB_LIGHTPROBE
  • But no ICON_OUTLINER_DATA_LIGHTPROBE

Ok - we could get @Andrzej Ambroz (jendrzych) to make a new icon for this, but it's unclear to me how it would differ from the one we already have?

Using ICON_OUTLINER_OB_LIGHTPROBE looks like this:

If for icon-naming consistency this isn't a problem, I think this can work.

We can use the object icon, it's just a small detail.

Normally for object data there is only an outline, while object is filled.

Ok you are right. How about we use the object icon for now, and I'll get in touch with @Andrzej Ambroz (jendrzych) about the ObData icon then. We also have a few other icons needed in places like Grease Pencil anyway.

This revision was automatically updated to reflect the committed changes.

I redesigned the Light Probe icons. Link to the updated icon set: https://blenderartists.org/t/new-icons-for-blender-2-8/1112701.

@Andrzej Ambroz (jendrzych) Thanks. Will make a patch for the update over the next few days.