Page MenuHome

Fix T60816: Specify subtype for plane_co in mesh.bisect operator
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Thu, Jan 24, 3:16 PM.

Details

Summary

I hesitate to commit this directly, because the same issue probably exists
in many other operators.

There are three possible solutions:

  1. Don't care, leave everything as is.
  2. Gradually fix all the instances of this problem.
  3. Fix all (most) of the instances of this problem at once.

What should we do?

Diff Detail

Repository
rB Blender

Event Timeline

RNA_def_float_vector_xyz is used for this purpose usually.

Fixing all is probably not too much work, I think there's only a handful. The axis/normal/scale and mask/image/clip/seq/uvedit stuff does not need units.

brecht@ws-reaper blender2.7 blender$ grep -r "RNA_def_float_vector(" editors/
editors/curve/editcurve.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f, "Axis", "Axis in global view space", -1.0f, 1.0f);
editors/mask/mask_select.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/transform/transform_ops.c:			prop = RNA_def_float_vector(ot->srna, "snap_point", 3, NULL, -FLT_MAX, FLT_MAX, "Point", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:				prop = RNA_def_float_vector(ot->srna, "snap_normal", 3, NULL, -FLT_MAX, FLT_MAX, "Normal", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 3, VecOne, -FLT_MAX, FLT_MAX, "Scale", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 3, VecOne, -FLT_MAX, FLT_MAX, "Scale", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 4, NULL, -FLT_MAX, FLT_MAX, "Values", "", -FLT_MAX, FLT_MAX);
editors/sculpt_paint/paint_image.c:	RNA_def_float_vector(ot->srna, "delta", 2, NULL, -FLT_MAX, FLT_MAX, "Delta", "Delta offset of clone image in 0.0..1.0 coordinates", -1.0f, 1.0f);
editors/space_clip/tracking_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/tracking_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/tracking_select.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_graph_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_dopesheet_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_sequencer/sequencer_add.c:	RNA_def_float_vector(ot->srna, "color", 3, NULL, 0.0f, 1.0f, "Color",
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/mesh/editmesh_extrude_spin.c:	RNA_def_float_vector(ot->srna, "center", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_extrude_spin.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f, "Axis", "Axis in global view space", -1.0f, 1.0f);
editors/mesh/editmesh_bisect.c:	prop = RNA_def_float_vector(ot->srna, "plane_co", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_bisect.c:	prop = RNA_def_float_vector(ot->srna, "plane_no", 3, NULL, -1.0f, 1.0f,
editors/mesh/editmesh_extrude_screw.c:	RNA_def_float_vector(ot->srna, "center", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_extrude_screw.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f,

Ok, I'll fix the instances of the problem I can find.

  • fix more instances of the same problem

I have to admit, there were much fewer instances of this problem than I expected.

I found that the guide_origin property does not seem to be used at all.
Maybe it should be removed?

Yes, I think guide_origin can be removed.

This revision is now accepted and ready to land.Thu, Jan 24, 4:45 PM
This revision was automatically updated to reflect the committed changes.