Page MenuHome

use the units system for cloth properties
ClosedPublic

Authored by Valentin (Poulpator) on Jan 26 2019, 1:02 PM.

Details

Summary

Correct use of units system for cloth properties (see task T60824 )

Not sure if i should use PROP_DISTANCE or PROP_UNIT_LENGTH

Diff Detail

Repository
rB Blender

Event Timeline

Using PROP_DISTANCE for a distance is correct.
It is actually defined as PROP_DISTANCE = 18 | PROP_UNIT_LENGTH.

Will commit this in a moment.

This revision is now accepted and ready to land.Jan 26 2019, 1:24 PM
This revision was automatically updated to reflect the committed changes.

@Brecht Van Lommel (brecht), I fear there is a name collision going on here...

I made very sure that I put exactly Valentin <Poulpator> as author into the commit. To make sure I don't mess up the order, I checked this commit of yours: rB657806691b.
Unfortunately, Phabricator seems to take the first name that matches any user name. And there is a username called valentin which is incorrectly linked to the commit now.. (I could not check this offline afaik)

There is probably no way to fix this now, but it's a bit embarrassing.

Should we just start asking for the email address every time we commit a change authored by someone else to avoid such collisions?

Too bad for credit, good if it's fixed, but no worries, I'm glad to be part of blender.

The git history is correct, which is the most important thing.

This happened because there was only a first name that happened to exactly match a username. As long as there is a first and last name it's fine, since usernames can't contain spaces.

We can look into fixing this in Phabricator, or avoid committing with author if there is only a first name.