Page MenuHome

Clamp value in sheen calculation to fix fireflies.

Authored by Alexander Court (spiegelball) on Jan 28 2019, 1:31 PM.

Diff Detail

rB Blender

Event Timeline

It seems better to fix the NaNs in the code that generates the normal?


Temporal -> Temporary

I have no problem with that. The meshes can gave issues that trigger precision issues in normal calculation and we have similar checks for the other bsdfs.


The following fit is only valid for N.V in [0..1] range. So it might even be better to clamp(f, 0.0, 1.0) instead.

Changed clamp range and corrected spelling.

Hey guys, is there anything I can do on this patch to get it approved? So many reports on those fireflies are coming in.

This revision is now accepted and ready to land.Feb 18 2019, 1:48 PM

Thanks @Clément Foucault (fclem)! Do I have to do something, it says "ready to land"?

This revision was automatically updated to reflect the committed changes.