Page MenuHome

Refactor drawing preview
ClosedPublic

Authored by Richard Antalik (ISS) on Feb 7 2019, 2:53 AM.

Details

Summary

Refactors preview drawing code with few functional modifications:

  • Fix T61241: Incorrect blank backdrop in VSE
  • Changing preview size does not affect drawn image size, only resolution.
    • Consistent behavior, when changing full-size / proxy / scene render size
    • Scopes are rendered in *same size* as source image
    • Over all, user does not have to readjust preview zoom.

Diff Detail

Repository
rB Blender

Event Timeline

Fix comment style
Remove unused variable

Brecht Van Lommel (brecht) requested changes to this revision.Feb 25 2019, 5:37 PM

Great improvement, just one minor comment.

source/blender/editors/space_sequencer/sequencer_draw.c
1084

Since this is a private function it should be static, and not use the BKE_ prefix because it is not in blenkernel/.

This revision now requires changes to proceed.Feb 25 2019, 5:37 PM

Fix private function name.

This revision is now accepted and ready to land.Feb 26 2019, 12:35 PM
This revision was automatically updated to reflect the committed changes.