Page MenuHome

BrushSet addon port to 2.80
ClosedPublic

Authored by CansecoGPC (CansecoGPC) on Feb 7 2019, 7:18 PM.

Details

Summary

Hi,

Updated registration to be compatible with new Blender API.
Fixed description.
Fixed import images with capital letters on Linux.

Diff Detail

Event Timeline

Fixed warnings on filename and filepath properties which should be annotations.

@Pablo Vazquez (pablovazquez) told me that i should not assign this task to someone, but wait until @Jacques Lucke (JacquesLucke) or @Campbell Barton (campbellbarton) did it?
Is that correct? Sorry for the inconvenience i could have caused...

Jacques Lucke (JacquesLucke) requested changes to this revision.Feb 19 2019, 12:35 PM
Jacques Lucke (JacquesLucke) added inline comments.
io_import_BrushSet.py
64

Better use file.lower().endswith(i) further down instead of duplicating all extension names.
(Maybe you can change i to extension in the same go...)

119

Syle: there should not be a space between filename and :

This revision now requires changes to proceed.Feb 19 2019, 12:35 PM
io_import_BrushSet.py
36

I think there is no need for this colon. With it it will be displayed as Import-Export: Import: BrushSet which looks wrong.

Fixed requested changes.

CansecoGPC (CansecoGPC) marked 2 inline comments as done.Feb 19 2019, 1:02 PM
CansecoGPC (CansecoGPC) added inline comments.
io_import_BrushSet.py
64

Something like this? I did tested and works fine.

CansecoGPC (CansecoGPC) marked an inline comment as done.
CansecoGPC (CansecoGPC) marked an inline comment as done.
io_import_BrushSet.py
64

Yes, that is what I meant. Maybe it would be even better to do this:

if any(file.lower().endswith(ext) for ext in ext_list):

Fixed the last request change. Let me know if there's anything else wrong. Thanks.

Fixed latest request.

CansecoGPC (CansecoGPC) marked an inline comment as done.Feb 19 2019, 1:19 PM

If @dan grauer (kromar) (original author of the addon) does not respond within a week, I'll merge this patch myself. (Please remind me if I forget it.)

This revision is now accepted and ready to land.Feb 19 2019, 1:32 PM

Hi @Jacques Lucke (JacquesLucke). Another week just passed away and @dan grauer (kromar) hasn't responded.
Hope you can merge this soon. Thanks.

Thanks for the reminder. I just committed it. I'm just a bit confused by how long it takes to update on.

When I clone the addons contrib repo, the commit is there. I guess we just have to wait a little until the commit is fully processed.