Page MenuHome

Changed units to correct ones
ClosedPublic

Authored by Vaishnav S (padthai) on Feb 11 2019, 5:22 PM.

Details

Summary

This revision is related to T60824.

Corrected units in Dynamic Paint, Modifiers (Wave, Wireframe), Smoke and Forcefield.
Also what's a suitable unit for flow_settings.texture_offset? Would PROP_UNIT_LENGTH be fine or should it be left at PROP_NONE for now?

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Feb 11 2019, 7:21 PM
source/blender/makesrna/intern/rna_modifier.c
1830

This speed and the dry_speed seem to work in opposite ways.

source/blender/makesrna/intern/rna_object_force.c
1279 ↗(On Diff #13607)

I already commented on this one somewhere else. Sometimes this seems to be a distance and sometimes an angle.

source/blender/makesrna/intern/rna_smoke.c
851 ↗(On Diff #13607)

I don't understand why this thickness is a length. Shouldn't it be more like a density?

source/blender/makesrna/intern/rna_modifier.c
1830

Will there be any changes in the units though?

source/blender/makesrna/intern/rna_smoke.c
851 ↗(On Diff #13607)

What do you propose it should be? Thought of using PROP_VOLUME, but this seemed more suitable.

Vaishnav S (padthai) added a comment.EditedFeb 12 2019, 5:12 PM

A separate density unit could also be made I guess; could be useful for some more properties.

We should probably start by simply fixing everything using the current unit types. Then we can make a note of the missing unit types and implement then later.

Corrected units in Modifiers (Bevel width), Scene and Curve.

This revision was automatically updated to reflect the committed changes.