Page MenuHome

Node headers should not respect theme alpha values
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Mon, Feb 11, 6:56 PM.

Details

Summary

As pointed out by @Pablo Vazquez (pablovazquez) in https://developer.blender.org/rB558d7dd90e56ca1b4dbf1b7b8b7b555791821148 , the theme color alpha should not be taken into account when rendering node headers.

I have to admit I'm not sure why the previous code only did this for TH_NODE. I did some quick tests and this change doesn't seem to break anything.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.EditedTue, Feb 19, 4:22 PM

I think it was only for TH_NODE because that is also the node background color, so the header is made a bit darker than that.

I would leave out the -20 only for TH_NODE, so you can specify the header color directly in the theme settings, and also to keep existing themes the same.

This revision now requires changes to proceed.Tue, Feb 19, 4:22 PM

I've updated with the requested changes.

This revision is now accepted and ready to land.Wed, Feb 20, 12:54 PM
This revision was automatically updated to reflect the committed changes.