Page MenuHome

Install_deps: Build tools for OIIO
Needs RevisionPublic

Authored by Diana Picus (rovka) on Feb 15 2019, 9:58 AM.

Details

Summary

Cycles and OpenGL draw tests need the idiff tool from
OpenImageIO, but install_deps.sh explicitly disables
building them.

This patch allows them to be built by default.

Diff Detail

Event Timeline

This revision is now accepted and ready to land.May 16 2019, 4:09 PM
Bastien Montagne (mont29) requested changes to this revision.May 16 2019, 4:13 PM

I would not enable that by default, this scripts is primarily intended to people who just want to build and use their own blender, not for the handful of devs that would actually run those tests. Please add it as an option of the script (ideally, a generic one like --enable-tests or something like that, that could be used in other places if/when needed, and that should also enable WITH_GTESTS and others in generated CMake config.

This revision now requires changes to proceed.May 16 2019, 4:13 PM

@Bastien Montagne (mont29), what are the caveats of enabling the tools?

More space-on-disk used, longer compiling time? I don’t think that is anything critical here, but we are trying to only build bare minimal requirements here, we explicitly strip all that we don’t need, imho things required only for tests should be optional (as are gtests building in blender itself).

The tools are just small wrappers that use the OIIO library, I don't think 1MB and a handful of seconds compile time makes much difference.