Page MenuHome

Fix T62059: Driver not updating in Color Ramp
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Mar 11 2019, 3:06 PM.

Details

Summary

I think I need some help here. The issue seems to be fixed
this way, but I guess it should be done differently because
get_node() is never used this way elsewhere.

What exactly is NodeType::Animation, and why are drivers
not part of it?

There seems to be another issue as well.

add_relation(Driver -> Driven Property) - Failed, but op_from (OperationKey(type: PARAMETERS, component name: '', operation code: DRIVER, 'nodes["ColorRamp"].color_ramp.elements[0].position')) was ok
add_relation(Driver -> Driven Property) - Could not find op_to (RnaPathKey(id: NTShader Nodetree, prop: 'position'))

Diff Detail

Repository
rB Blender
Branch
shader-driver (branched from master)
Build Status
Buildable 3101
Build 3101: arc lint + arc unit

Event Timeline

You don't need to have any checks, just update to rB422d4541f47and connect PARAMETERS to ShadingParamaters.

NodeType::ANIMATION is for f-furve and NLA, Drivers are much more granular and can affect individual parameters of an ID, so they live in parameters component.

  • only connect parameters to shading_parameters

Looks good to me.

This revision is now accepted and ready to land.Mar 11 2019, 3:52 PM
This revision was automatically updated to reflect the committed changes.