Page MenuHome
Differential D4497

Fix T62059: Driver not updating in Color Ramp
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 11 2019, 3:06 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Maniphest Tasks
T62059: ColorRamp doesn't update when a color stop is driven by expression
Commits
rBS836f3494d759: Fix T62059: Driver not updating in Color Ramp
rB836f3494d759: Fix T62059: Driver not updating in Color Ramp
Summary

I think I need some help here. The issue seems to be fixed
this way, but I guess it should be done differently because
get_node() is never used this way elsewhere.

What exactly is NodeType::Animation, and why are drivers
not part of it?

There seems to be another issue as well.

add_relation(Driver -> Driven Property) - Failed, but op_from (OperationKey(type: PARAMETERS, component name: '', operation code: DRIVER, 'nodes["ColorRamp"].color_ramp.elements[0].position')) was ok
add_relation(Driver -> Driven Property) - Could not find op_to (RnaPathKey(id: NTShader Nodetree, prop: 'position'))

Diff Detail

Repository
rB Blender
Branch
shader-driver (branched from master)
Build Status
Buildable 3102
Build 3102: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) added a comment.Mar 11 2019, 3:36 PM

You don't need to have any checks, just update to rB422d4541f47and connect PARAMETERS to ShadingParamaters.

NodeType::ANIMATION is for f-furve and NLA, Drivers are much more granular and can affect individual parameters of an ID, so they live in parameters component.

Jacques Lucke (JacquesLucke) updated this revision to Diff 14117.Mar 11 2019, 3:43 PM
  • only connect parameters to shading_parameters
Sergey Sharybin (sergey) accepted this revision.Mar 11 2019, 3:52 PM

Looks good to me.

This revision is now accepted and ready to land.Mar 11 2019, 3:52 PM
Closed by commit rB836f3494d759: Fix T62059: Driver not updating in Color Ramp (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 11 2019, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14117

View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...