Page MenuHome

Pre-fill bug-reports.
AbandonedPublic

Authored by LazyDodo (LazyDodo) on Mar 13 2019, 1:59 AM.

Details

Summary

There is currently a large number of 'less than ideal in quality' tickets coming in the tracker, people don't fill out the required information, or just don't know it ("what's a hash?")

Blender has a 'Help -> Report Bug' option , that used to open our stock bug report form, this diff changes the URL to supply a pre-filled template with the commit, build-date, platform version and GPU information pre-filled in.

not sure who to put as reviewers, so i winged it :)

If this diff lands, I prefer if we updated the bug report form on the website with a text to encourage Help -> Report Bug usage so there will be a higher number of 'better quality' tickets coming in.

Diff Detail

Event Timeline

Hi, testing the patch and result looks fine:

System Information
Operating system: Linux-4.20.13-1-default-x86_64-with-glibc2.9 64 Bits
Graphics card: Mesa DRI Intel(R) Ivybridge Mobile Intel Open Source Technology Center 4.2 (Core Profile) Mesa 18.3.4

Blender Version
Broken: version: 2.80 (sub 47), branch: master (modified), commit date: 2019-03-10 14:23, hash: rB1cc8f9d463a7
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Sebastian Parborg (zeddb) requested changes to this revision.Mar 13 2019, 11:10 AM

Other than my nitpick, I think this is fine. I didn't have any issues when I tried it out either.

release/scripts/startup/bl_ui/space_topbar.py
36

Trailing space (just remove the space char at the end of the line)

This revision now requires changes to proceed.Mar 13 2019, 11:10 AM
Jacques Lucke (JacquesLucke) added inline comments.
release/scripts/startup/bl_ui/space_topbar.py
892

I'd not call a variable tmp that is used that often.
Why do you not use tmp +=?

I think this would look much better when you use multiline string interpolation.

For example:

import platform
import textwrap
import struct

bug_report_body = textwrap.dedent(f'''\
    Operating system: {platform.platform()} {8 * struct.calcsize("P")} Bits
    Graphics card: ...
    ''')
release/scripts/startup/bl_ui/space_topbar.py
30

This function seems to be quite hacky.
What does prepr stand for?

release/scripts/startup/bl_ui/space_topbar.py
21–24

For fast startup times we avoid importing too many modules, these can be loaded as needed.

892–917

Accumulating strings like this isn't efficient, better append to a list, then use "".join(tmp).

I think this is great, if the Python implementation comments are addressed I think this is good to go in.

I can update the form to recommend reporting bugs this way.

In the future we can consider adding even more information like system info, info editor log, etc.

Thanks, committed rBd555f6a4abc50ab7fbf5ecd9d85965aeef0f4335 - refactored to use StringIO (simulate file writing), and move into own module so as not to impact startup times.

The Report a Bug button for addons could use a similar improvement.