Page MenuHome

Fix T62757: Mirror operator fails with EXEC_DEFAULT

Authored by Dalai Felinto (dfelinto) on Mar 19 2019, 10:47 PM.


Diff Detail

rB Blender
fix-mirror-exec (branched from master)
Build Status
Buildable 3189
Build 3189: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) planned changes to this revision.Mar 19 2019, 11:03 PM

The patch as it is it is wrong.
But it also seems that a lot of the changes came from: rB1bfbfa281046b9d600a1604794fce3aadd7f5cf7 so perhaps the original bug was somehow intentional/by design? I will investigate a bit further.

@Dalai Felinto (dfelinto) The constraints were removed from the transform redo panel because it doesn't make sense to move/rotate/scale.

However, for Mirror, we do need a way to adjust the axis of mirroring.

So, we could add it just for Mirror? Or add a new 'Axes' operator setting with X, Y and Z toggles?

Patch fixed. Technically this can be committed in two parts.

First there is a fix for the (t->flag & T_MODAL) logic being redundant
(we test for this twice).

Second there is the change and:

- if (t->flag & T_MODAL) {
+ if ((t->mode == TFM_MIRROR) || (t->flag & T_MODAL)) {

Bug fixed already