Page MenuHome

UI: Do not show full action range
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Mar 20 2019, 4:53 PM.

Details

Summary

This is a request by @Hjalti Hjálmarsson (hjalti).
He will write the reasoning below.

Left is old, right is new:

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

@Hjalti Hjálmarsson (hjalti), can you explain the reasoning.

The comments refer to the NLA, but seems this has some effect without it. Might just be some legacy code that doesn't make sense anymore?

Sorry, I didn't see the notification so I'm a bit late to the game...

Essentially this comes down to clarity and usability. In the old way there's a highlighted boundary to illustrate where the first-most and last-most keys are and this is visually very strong (even stronger than the frame range) even though it's quite trivial information to the animator. I can't think of a single example where I needed that information at all times. The new way gives priority to visualizing the frame range, something that's crucial to the animator at all times.

I'm guessing the idea is that if you use this action as a strip in the NLA, it's good to have an indicator of the start and end of that strip.

The comment in the code seems to say that this would only show when you have this action in the NLA, but the behavior does not match that. So this seems broken.

If this feature is useful for the NLA it can always be added back with an implementation that actually works.

This revision is now accepted and ready to land.Apr 12 2019, 7:57 PM
This revision was automatically updated to reflect the committed changes.