Page MenuHome

UI: Move Object Origin Size to Themes & cleanup
ClosedPublic

Authored by George Vogiatzis (Gvgeo) on Apr 7 2019, 4:23 PM.

Details

Summary
  1. T61557 Move Object Origin Size to Themes (also changed size from short to char).
  2. Remove obcenter_dia from ED_view3d_draw_depth.

Used for drawing with grease-pencil on surface rBe2f5d31453c8. With the removal of blender Internal rB51b796ff1528, is no longer need.

Diff Detail

Repository
rB Blender

Event Timeline

I cannot find a way to keep the old value, except keeping the userdef->obcenter_dia too.

source/blender/editors/space_view3d/view3d_draw.c
728

Remove obcenter_dia from ED_view3d_draw_depth.
Used for drawing with grease-pencil on surface rBe2f5d31453c8. With the removal of blender Internal rB51b796ff1528, is no longer need.
Last used here. https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_view3d/drawobject.c;785e8a636a293941a4295e669cb5aeecfafae039

source/blender/makesdna/DNA_userdef_types.h
300

I have no idea why so many _pad in the two structs. Tried to keep the change simple.

George Vogiatzis (Gvgeo) edited the summary of this revision. (Show Details)Apr 7 2019, 4:30 PM

It is been a while. I don't know if this patch fall under the radar, postponed for 2.81 or just didn't get to it yet. Just poking to make sure you didn't missed it.
@William Reynish (billreynish) I put only you as a reviewer, to check it first, before code review. Should have added campbellbarton and Brecht from the start?

George Vogiatzis (Gvgeo) retitled this revision from Move Object Origin Size to Themes & cleanup to UI: Move Object Origin Size to Themes & cleanup.Apr 30 2019, 9:47 AM
This revision is now accepted and ready to land.May 1 2019, 12:46 PM

Doesn't seem to apply cleanly against latest master?

George Vogiatzis (Gvgeo) updated this revision to Diff 15035.
  1. Update for versioning and clang format changes.
  2. Removed leftover origin size from viewport preferences.
This revision was automatically updated to reflect the committed changes.