Page MenuHome

Linking Embree Libraries Accordingly
ClosedPublic

Authored by Maruf Sarker (maruf) on Apr 18 2019, 6:43 AM.

Details

Summary

Static linking error discussed in devtalk should be fixed by this patch.
They have discussed and found the solution. I am just re-checking.
I have also faced the issue.

According to Embree building documentation:

Compiling Embree > CMake Configuration
EMBREE_STATIC_LIB: Builds Embree as a static library (OFF by default). Further multiple static libraries are generated for the different ISAs selected (e.g. embree3.a, embree3_sse42.a, embree3_avx.a, embree3_avx2.a, embree3_avx512knl.a, embree3_avx512skx.a). You have to link these libraries in exactly this order of increasing ISA.

Devtalk Discussion: https://devtalk.blender.org/t/ubuntu-18-04-error-when-building-not-first-time-building-on-ubuntu/6723

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Apr 18 2019, 10:41 AM
This revision was automatically updated to reflect the committed changes.

Thanks Brecht :)
Also, Thanks Roel for the award :)
:)

I'm slightly weirded out the patch i posted on devtalk for @Stefan Werner (swerner) to validate and help some people out short term, is showing up on the tracker like this

I'm slightly weirded out the patch i posted on devtalk for @Stefan Werner (swerner) to validate and help some people out short term, is showing up on the tracker like this

Thank you :)
I was facing the problem too, so checked and submitted the patch. :)

LazyDodo (LazyDodo) added a comment.EditedApr 18 2019, 2:48 PM

I think you misread that, i'm upset you are posting other peoples work. 'thank you' is a strange response to that

And I saw too late that @LazyDodo (LazyDodo) came up with that solution on devtalk first... Sorry dude!

Ah, I wasn't aware this patch was written by someone else. It should have been attributed to @LazyDodo (LazyDodo) then.

I assume it wasn't submitted intentionally to take credit away though, it's not immediately obvious how these things work.

Don't care who's name is on the commit honestly, i could have committed it my self, but wanted to run it by swerner first , seeing it on the tracker a day later just weirded me out, (not actually upset, but i think 'weirded out' got lost in translation)

Whatever makes the compiler happy is fine with me.