Page MenuHome

Cleanup: Use generics properties for arrow keys navigation(walk_select)
ClosedPublic

Authored by Valentin (Poulpator) on May 1 2019, 12:41 AM.

Details

Summary

This patch refactor arrow keys navigation to move properties and enum to generic ED_select_utils.h and property to WM_operator_properties_select_walk_direction()

No functional change

Diff Detail

Repository
rB Blender

Event Timeline

Valentin (Poulpator) retitled this revision from refactor: arrow keys navigation(walk_select), move properties and enum to generic ED_select_utils.h and property to WM_operator_properties_select_walk_direction() to refactor: arrow keys navigation(walk_select).May 1 2019, 12:46 AM
Valentin (Poulpator) edited the summary of this revision. (Show Details)

Think this is fine, although better wait until it's used somewhere else than file browser (outliner most likely). Also, might make sense to add UI_ prefix, so UI_SELECT_WALK_FOO to make clear this is UI only.

This revision is now accepted and ready to land.May 3 2019, 10:59 PM

Nice. I’m guessing this will make it easier to re-use this for other places such as the Outliner?

  • Updated the diff to master
  • Addressed comment

I guess it could apply for code quality day

Valentin (Poulpator) retitled this revision from refactor: arrow keys navigation(walk_select) to Cleanup: Use generics properties for arrow keys navigation(walk_select).Feb 7 2020, 10:48 PM
Valentin (Poulpator) edited the summary of this revision. (Show Details)

Just tested this. I don't see any reason why it shouldn't be committed.