Page MenuHome

Fix T60825: Save transform values only when confirm if there is a constrain.
Needs ReviewPublic

Authored by George Vogiatzis (Gvgeo) on May 2 2019, 8:31 AM.

Details

Summary

Bug T60825: Transform operator gives wrong position when pressing MMB, or shift with constrain axis.

Fixed by saving transform values only when confirm, if there is a constrain.

Diff Detail

Repository
rB Blender

Event Timeline

source/blender/editors/transform/transform.h
643

I suspect that half of the variables in struct are unused, depending on case.
Is it really okay to create a different variable in struct for each case?
I didn't check, to confirm. But must be an other free to use instead.

George Vogiatzis (Gvgeo) retitled this revision from FIX T60825: Save transform values only when confirm if there is a constrain. to Fix T60825: Save transform values only when confirm if there is a constrain..May 3 2019, 3:54 PM

Your solution is interesting, and may even help solve other problems that have already been reported.
However the TransInfo struct is already large and confusing. It is also worth remembering that there are many types of transformation that don't need a values_final (like rotating UV maps).
I personally would prefer a solution that simplifies this struct among the various forms of transformation.
But the final decision is with Campbell.

If this is good, will have to apply the same change to applyResize and applyRotation functions.