Page MenuHome

Fix T64093: Limit Max size of Lookdev preview balls.
AbandonedPublic

Authored by George Vogiatzis (Gvgeo) on May 3 2019, 2:26 PM.

Details

Summary

Bug T64093 Look Dev Preview's balls are huge!
Commit e66629c12825 made the Lookdev preview balls resize with UI scale.

This commit changes:

  1. Shrink the size of the balls 10%. This matches the base size, more closely, to the size prior the dpi change.
  2. Limit the max size of the Lookdev preview balls, from the x size of the 3dview area.

Diff Detail

Repository
rB Blender

Event Timeline

Short of adding an extra option for the ball size.
Limiting the max size (pre UI.scale) was the only solution.
While keeping both the functionality of UI scale, and the resize from x size.

Resizing both the size of the area, and dpi made the balls big.

Cannot have everything perfect.
1080p and 4k@200%Scale, will have different size. Because with the current value, the size limit at about 2500 pixels. (default layout workspace has about 1500 pixels.)
Is this good enough?

George Vogiatzis (Gvgeo) retitled this revision from FIX T64093: Limit Max size of Lookdev preview balls. to Fix T64093: Limit Max size of Lookdev preview balls..May 3 2019, 3:54 PM

Thanks for this patch. I'm also in favor of adding a UI option for the max size (or maybe absolute size) but this will do it for now.

This revision is now accepted and ready to land.May 3 2019, 5:17 PM

Used instead D4793 add Look Developer Balls Size option. b8d806caf7c9