Page MenuHome

Proposal of fix for T64342: Incorrect snapping of focus object in camera view.
AbandonedPublic

Authored by Germano Cavalcante (mano-wii) on May 10 2019, 7:44 PM.

Details

Summary

Since rBa32588b17473, the T_CAMERA flag (which indicates whether the camera is affected by the transformation) is set whenever the camera is marked to update due to some dependency relation.
However this flag is unnecessary if the dependency is with the focus object.
And this brings inconveniences like the T64342.
This patch proposes to identify and skip this particular case.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 3577
Build 3577: arc lint + arc unit

Event Timeline

Ideally we would have a direct way to check if an object is being transformed - if other relationships are causing errors.

source/blender/editors/transform/transform_conversions.c
9715–9716

check the object type is OB_CAMERA before casting.

source/blender/editors/transform/transform_conversions.c
9716–9717

I am not sure what is the value of referencing bug reports. This doesn't make it any more clear why stuff is happening the way it does happen. There is only a vague explanation in the commit message. Such information should be put into the comments, so you don't spent your life chasing bug reports, reading comments there, then trying to extract more information from a commit message.

Germano Cavalcante (mano-wii) marked 2 inline comments as done.May 13 2019, 7:43 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 15321.
  • Error-proof...