Page MenuHome

VSE: add movie strips on top of audio
ClosedPublic

Authored by Richard Antalik (ISS) on May 16 2019, 2:15 AM.

Details

Summary
  • add movies to channel above free slot (no check for 2 free slots)
  • add sound to the free slot

This code is bad just by looking at it :[
I guess that worst is, that it silently overrides channel operator property.
We can not set channel in python anyway and there is another code that can override decision made by this operator...

This seems to be rabbithole I don't really want to deal with at this point - see T59540: VSE timeline manipulation API

Diff Detail

Repository
rB Blender
Branch
T64661 (branched from master)
Build Status
Buildable 3646
Build 3646: arc lint + arc unit

Event Timeline

source/blender/editors/space_sequencer/sequencer_add.c
169

Maybe I should add check if the channel property is set here.
That will at least restore it's function

  • don't override channel settings if channel property is set
Brecht Van Lommel (brecht) requested changes to this revision.May 18 2019, 8:33 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/space_sequencer/sequencer_add.c
176

frame_end should be channel?

This revision now requires changes to proceed.May 18 2019, 8:33 PM
This revision is now accepted and ready to land.Sat, May 18, 10:17 PM