Page MenuHome

DrawManager: Color Management
ClosedPublic

Authored by Jeroen Bakker (jbakker) on May 21 2019, 12:23 PM.

Details

Summary

The draw manager used to determine if the view transform should be
applied by checking if the scene was not rendered to an offscreen image.

As the sequencer needs to render to an offscreen image with the view
transform applied we need to separate the do_color_management from the
is_image_render.

Diff Detail

Repository
rB Blender

Event Timeline

Also not 100% sure if/how we should attach this to Grease Pencil.

GP copies the is_image_render locally and turns off tonemapping for when rendering. Colors in the viewport vs image rendering are different in filmic (current state in master). I think we should also connect the tonemapping setting to DRW_state_do_color_management.

source/blender/draw/intern/draw_manager.c
300–301

Is this comment still valid?

Removed commend
Disable tonemapping when color management needs to be performed.

This revision is now accepted and ready to land.May 31 2019, 12:26 PM
This revision was automatically updated to reflect the committed changes.