Page MenuHome

python templates: update operator_modal_draw to 2.8
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on May 21 2019, 1:57 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested changes to this revision.May 21 2019, 2:04 PM
Jacques Lucke (JacquesLucke) added inline comments.
release/scripts/templates_py/operator_modal_draw.py
5

Better move this line into draw_callback_px. Getting the shader is not allowed when Blender is started without UI, so it should not be executed when not needed.

This revision now requires changes to proceed.May 21 2019, 2:04 PM

dont get shader when in background mode

Philipp Oeser (lichtwerk) marked an inline comment as done.May 21 2019, 2:17 PM

Just one minor thing. Other than that seems fine.

release/scripts/templates_py/operator_modal_draw.py
22

couldn't you just pass self.mouse_path in here directly?

This revision is now accepted and ready to land.May 21 2019, 2:21 PM

Just one minor thing. Other than that seems fine.

Ha, totally true :) ... maybe a tiny tad less readable (for a template), but will commit with your suggestion (seems better after all)...

This revision was automatically updated to reflect the committed changes.