Page MenuHome

Revival of the OpenVDB Particle Mesher Modifier
Needs ReviewPublic

Authored by Martin Felke (scorpion81) on May 30 2019, 5:11 PM.

Details

Summary

This patch is an attempt to update D1008 (Particle Mesher Modifier by @Kévin Dietrich (kevindietrich)) for 2.8.
Currently it still has an issue with the particle system, where totpart seems to be 0 all the time and
i am not sure how to properly get the evaluated version (aka a particlesystem WITH particles actually).
Putting this here so other devs may have a look at it as well.
The idea behind this new attempt is to have the particle meshing based on OpenVDB now too, as well as
having it in a separate new modifier. This was discussed with @Brecht Van Lommel (brecht) on blender.chat.

Diff Detail

Repository
rB Blender

Event Timeline

Martin Felke (scorpion81) planned changes to this revision.

Setting on "Planned Changes" since the particle issue is to be solved yet.

add an inline comment marking the area of the problem

source/blender/modifiers/intern/MOD_openvdb_util.c
56

what is going wrong here... what needs to be eval'ed ? object ? modifier ? particlesystem ? all of it ? or some combination ? so far it either led to totpart == 0 or the eval'ed particlesystem being NULL

Solved the particle issue by treating the particlemesher modifier like the dynamic paint and smoke modifiers regarding particle system copy and deletion.
Fixed some crash bugs regarding loading and saving as well as copying objects with this modifier too.
Need to deal properly with Ngons still for the mask object, like using looptris or something like that.
But i think a first pass of general review may already happen.

since @Brecht Van Lommel (brecht) and me discussed the revival of the particlemesher in blender.chat, setting him as reviewer here.