Page MenuHome

Drag to box select in Dopesheet
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Jun 5 2019, 2:44 PM.

Details

Summary

This includes refactoring of the mouse_action_keys to
make it easier to just detect if there is a key under
the mouse. The refactoring mostly consists of extracting
methods and reducing vertical scope of variables.

Individual Commits:

  • initial drag to box select
  • Extract Method: actkeys_find_element_under_position
  • Extract Method: actkeys_list_element_to_keylist
  • don't use rctf when only xmin and xmax are required
  • Extract Method: actkeys_find_key_in_list_element
  • Extract Method: actkeys_find_key_at_position
  • cleanup
  • don't start box select over keyframe
  • use OPERATOR_PASS_THROUGH

Diff Detail

Repository
rB Blender

Event Timeline

Seems to work correctly - couldn't make it fail.

This revision is now accepted and ready to land.Jun 5 2019, 2:58 PM
This revision was automatically updated to reflect the committed changes.