Page MenuHome

Create new cursor for Grease Pencil paint mode
Needs RevisionPublic

Authored by Antonio Vazquez (antoniov) on Jun 6 2019, 7:58 PM.

Details

Summary

This new cursor would be used in all paint modes, but now only tested in Grease Pencil

Related to task T62446

Diff Detail

Event Timeline

The diff file isn't working.I'm getting the errors

error: scripts/startup/bl_ui/space_toolsystem_toolbar.py: No such file or directory
error: blender/editors/gpencil/gpencil_paint.c: No such file or directory
error: blender/makesrna/intern/rna_wm_api.c: No such file or directory
error: blender/windowmanager/intern/wm_cursors.c: No such file or directory
error: blender/windowmanager/wm_cursors.h: No such file or directory

We need a review to be sure we don't break or missing anything.

William Reynish (billreynish) accepted this revision.EditedJun 6 2019, 8:08 PM

This works well I think.

Looks like this:

In fact, this patch makes it already work in all paint and sculpt modes, so good job!

It's nice to finally get rid of the arrow cursor when painting and sculpting.

Later, we should probably add an option to completely hide the cursor, if you are using a direct input device, such as a Cintiq or iPad Pro, or other similar devices for input. But that is a separate thing that can be added and reviewed separately.

This revision is now accepted and ready to land.Jun 6 2019, 8:08 PM

Later, we should probably add an option to completely hide the cursor, if you are using a direct input device, such as a Cintiq or iPad Pro, or other similar devices for input.

Yes, to have this option is mandatory... implement the parameter is easy, but some changes are required to hide always the cursor (I guess in Ghost module).

Ony one concern, we would hide arrow only or all cursors? for example when scale, cut or anything that show a different cursor? maybe the solution would be hide any cursor in a predefined array.

@Antonio Vazquez (antoniov) Well yes, if you use a Cintiq/iPad Pro style device, you have no use for the cursor at all, so it really should be a general thing.

The main issue is, I suppose, that if you accidentally enable this option when using a mouse, your cursor will disappear and it will be hard to re-enable it if there is no cursor :)

Ideally I suppose we should make it smart, so that it could somehow detect the input device, although that may not always be possible.

I think is possible detect if you have a tablet device connected, so the hide cursors only must work if this device type is detected.

@Antonio Vazquez (antoniov) Well yes, if you use a Cintiq/iPad Pro style device, you have no use for the cursor at all, so it really should be a general thing.
The main issue is, I suppose, that if you accidentally enable this option when using a mouse, your cursor will disappear and it will be hard to re-enable it if there is no cursor :)
Ideally I suppose we should make it smart, so that it could somehow detect the input device, although that may not always be possible.

We could have it so you have a setting for mouse and an external input device so when you remove the external input device it goes back to the mouse setting.

  • Update some tools with the new cursor to keep consistency.

Committed in a412f49e7580

I've reverted this change because it was only supposed to affect grease pencil, but also ended up affecting sculpt mode. This then spawned long discussion about the ideal cursor shape, and that's really not the simple and safe change I approved. Since this has not been quickly resolved I'm reverting the commit.

Unless someone can come up with a simple and safe change, this will have to move to 2.81. After the UI freeze is not the time for UI experimentation.

This revision is now accepted and ready to land.Jun 16 2019, 8:31 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jun 16 2019, 8:32 PM
This revision now requires changes to proceed.Jun 16 2019, 8:32 PM