Page MenuHome

Add option to choose Display and View transform when saving images
Needs RevisionPublic

Authored by Lukas Stockner (lukasstockner97) on Jun 13 2019, 2:27 AM.

Details

Summary

Currently, Blender always uses the scene's display and view transforms
when saving images through the Save Image operator or the File Output node.

With this commit, settings are exposed in the image format panel that
can be used to select a different display, view, look, exposure etc.

The code was already pretty much there since 2012 but was left disabled.
@Sergey Sharybin (sergey), is there any issue that caused you to keep it disabled?

The only downside I can see is that if a user adds a File Output node
and then changes the scene settings, the node will no longer mirror these
changes. Maybe adding a checkbox "Use custom color management" would help?

Diff Detail

Repository
rB Blender
Branch
image-colorspace-out (branched from master)
Build Status
Buildable 3869
Build 3869: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested changes to this revision.Jun 13 2019, 10:36 AM

The code was already pretty much there since 2012 but was left disabled. @Sergey Sharybin (sergey) Sharybin (sergey), is there any issue that caused you to keep it disabled?

Were too much intrusive changes already, also needed good interface decision to be really helpful.

The current patch i don't find particularly useful for artists: it makes saving your image a gamble. You would never know whether your settings are actually ruining the look of the image.
It also doesn't facilitate way more common request: being able to save files in a color space different from scene linear one. To me it seems exposing a lot of settings which will almost never be used.

But even if others find this specific feature useful, it doesn't work that great and have bugs:

  • File Save allows you to color space settings for any image, not only for rendered one. So if you open PNG, hit Image -> Save a Copy, choose "False Color" and save another PNG, none of the transform is applied.
  • initialization of color management from scene for opened images is wrong: you don't want to apply Filmic by default when saving textures.
  • Changing Display Device does not update list of available views.
  • Outcome from previous one: trying to save render in XYZ display ends up in abort: this is because color management is asked for Filmic view which does not exist for XYZ.
This revision now requires changes to proceed.Jun 13 2019, 10:36 AM

We have Save As Render, and if that is enabled it could give the option to change the display and view transforms but initialize them to the ones from the scene.

The main thing that's missing though is indeed saving to a specific color space without display and view transforms.