Page MenuHome

Fix T61777: Proportional editing does not influence all objects in edit mode
Needs ReviewPublic

Authored by Alan Troth (Al) on Jul 1 2019, 4:44 PM.

Details

Summary

Fix T61777: Proportional editing does not influence all objects in edit mode

  • The biggest change is in transform_conversions.c::set_prop_dist(...). When searching for the nearest selected vertex the current implementation of the set_prop_dist only looks for the nearest selected vertex from a single object, in this patch the function searches all selected vertices across all objects.
  • Many functions with the name createTransXxxxx have had small changes made so that when proportional editing, the TransDataContainer will be filled even if that object has no selected vertices.
  • A check has been made to make sure there is at least one selected vertex, if none are found the transform operation exits early.

Diff Detail

Repository
rB Blender
Branch
T61777_MultiEdit_Prop (branched from master)
Build Status
Buildable 4466
Build 4466: arc lint + arc unit

Event Timeline

Alan Troth (Al) created this revision.Jul 1 2019, 4:44 PM
Alan Troth (Al) retitled this revision from Multi object set prop dist. With commented out timing code. With original single object code still present. to Fix transform_conversions.c::set_prop_dist(...) to check all selected vertices when finding nearest selected vertex..Jul 1 2019, 5:01 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)
Alan Troth (Al) planned changes to this revision.Aug 13 2019, 5:18 PM

I'm planning on adding the extra code to fully get multi object proportional editing working.

Alan Troth (Al) updated this revision to Diff 17159.EditedAug 15 2019, 3:40 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)

Additions to make it a complete multi-object propotional editing patch.

  • Functions with the name createTransXxxxx have had small changes made so that when proportional editing, the TransDataContainer will be filled even if that object has no selected vertices.
  • A check has been made to make sure there is at least one selected vertex, if none are found the transform operation exits early.
Alan Troth (Al) edited the summary of this revision. (Show Details)Aug 15 2019, 4:05 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)
Alan Troth (Al) retitled this revision from Fix transform_conversions.c::set_prop_dist(...) to check all selected vertices when finding nearest selected vertex. to Fix proportional editing so that it works with multi object editing.Aug 15 2019, 4:17 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)Aug 15 2019, 4:42 PM
Alan Troth (Al) retitled this revision from Fix proportional editing so that it works with multi object editing to Fix T61777 - Fix proportional editing so that it works with multi object editing.Aug 15 2019, 4:49 PM
Alan Troth (Al) retitled this revision from Fix T61777 - Fix proportional editing so that it works with multi object editing to Fix T61777: Proportional editing does not influence all objects in edit mode.Aug 15 2019, 4:52 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)
Alan Troth (Al) updated this revision to Diff 17196.EditedAug 16 2019, 4:47 PM
Alan Troth (Al) edited the summary of this revision. (Show Details)

Updated to master.

I may not have caught all the multi-edit updates needed, but as far as I can tell if proportional editing worked in 2.79, it should work with multi-editing in after this patch.