Page MenuHome

Rename burn to color burn
Needs ReviewPublic

Authored by Eitan (EitanSomething) on Jul 4 2019, 10:31 PM.

Diff Detail

Repository
rB Blender
Branch
namingInconsistancies (branched from master)
Build Status
Buildable 3987
Build 3987: arc lint + arc unit

Event Timeline

Eitan (EitanSomething) edited the summary of this revision. (Show Details)Jul 4 2019, 10:33 PM
Eitan (EitanSomething) edited the summary of this revision. (Show Details)
Eitan (EitanSomething) retitled this revision from Burn rename to color burn to Rename burn to color burn.Jul 4 2019, 10:42 PM

That does seem like a good idea, to properly differentiate "Color Burn" from "Linear Burn".

However, since you are touching that area, isn't there a similar issue with "Dodge"? What kind of dodge? I have a suspicion (haven't actually checked LOL) That "Dodge" should be "Color Dodge" and "Add" is actually "Linear Dodge". Again, I could very well be wrong so needs checking.

From wikipedia

"Color Dodge" blend mode divides the bottom layer by the inverted top layer. This lightens the bottom layer depending on the value of the top layer: the brighter the top layer, the more its color affects the bottom layer. Blending any color with white gives white. Blending with black does not change the image. The operation is not invertible due to possible clipping of highlights. (The clipping happens in the same area as for the Linear Dodge.) When top layer contains a homogeneous color, this effect is equivalent to changing the white point to the inverted color. The perceived contrast increases when there is no clipping.

"Linear Dodge" blend mode simply sums the values in the two layers (also known as additive blending). Blending with white gives white. Blending with black does not change the image. When top layer contains a homogeneous color, this effect is equivalent to changing the output black point to this color, and (input) white point to the inverted color. The contrast is decreased when there is no clipping.

Ah yes - my bad - didn't see that thread.

Typo in your change in rna_sequencer.c at line 1460: "COLIORBURN"

Eitan (EitanSomething) updated this revision to Diff 16223.EditedJul 5 2019, 10:59 PM

Fix spelling mistake rna_sequencer.c at line 1460: "COLIORBURN" now "COLORBURN"

I think you'd want to capitalize the "Burn" in "Color Burn" to match the case of the other options.

And I could be wrong, but think some of the changes in the enum lists (rna_material.c & rna_sequencer.c) could break python scripts. You might need to keep the second field the same as it is now to work with existing scripts. So in the change in rna_sequencer.c, 2794, might have to be:

{SEQ_TYPE_COLORBURN, "BURN", 0, "Color Burn", ""},

I don't really use Python in Blender so I could be wrong about this.

  • Capitalization fix "Color burn" now "Color Burn"
  • Capitalization fix "Color burn" now "Color Burn"

And I could be wrong, but think some of the changes in the enum lists (rna_material.c & rna_sequencer.c) could break python scripts. You might need to keep the second field the same as it is now to work with existing scripts. So in the change in rna_sequencer.c, 2794, might have to be:

{SEQ_TYPE_COLORBURN, "BURN", 0, "Color Burn", ""},

I don't really use Python in Blender so I could be wrong about this.

And I could be wrong, but think some of the changes in the enum lists (rna_material.c & rna_sequencer.c) could break python scripts. You might need to keep the second field the same as it is now to work with existing scripts. So in the change in rna_sequencer.c, 2794, might have to be:

{SEQ_TYPE_COLORBURN, "BURN", 0, "Color Burn", ""},

I don't really use Python in Blender so I could be wrong about this.

I have asked in https://blender.chat/channel/blender-coders if it will break the python api and I will proceed as if it doesn't.

Changing from
{SEQ_TYPE_COLORBURN, "BURN", 0, "Color Burn", ""},
To
{SEQ_TYPE_COLORBURN, "COLOR_BURN", 0, "Color Burn", ""},
Is that something that can be done in 2.81?

  • Replace COLOR_BRUN with BURN to avoid breaking python api
  • rename MA_RAMP_COLOR_BURN to MA_RAMP_BURN to maintain MA_RAMP_ consistancy

This change makes sense, but we might as well fix the inconsistencies with all the blending modes at once. So, as @Harley Acheson (harley) suggests, same goes to Color Burn etc.