Page MenuHome

Fix T63570: Proportional editing resets scaling along Y and Z axis on mouse wheel
ClosedPublic

Authored by Germano Cavalcante (mano-wii) on Jul 10 2019, 12:55 AM.

Details

Summary

applyResize(...) considers that t->values always represents a ratio.
But this is only true with the MOUSEMOVE event.
The solution proposed is to never change t->values the result of the final transformation is now written to t->value_final.

Report: T63570

Diff Detail

Repository
rB Blender

Event Timeline

This comment has been deleted.
  • Do not write on t->values when applying transformations.
  • Comments and rename T_AUTOVALUES to T_INPUT_IS_VALUE_FINAL
Campbell Barton (campbellbarton) requested changes to this revision.Fri, Aug 2, 5:33 AM

Looks good and tested, it seems to work well for UV/sequencer/extrude-tool, interactive & redo transform.

Would still like it to be very clear when to use each of these values, since auto-values used to be an exception and now this is using both values and values_final together in a way thats easier to mix-up.

source/blender/editors/transform/transform.h
665–672

It wouldn't hurt to be a bit more explicit about when each of these is used.

  • Which has snapping applied, number input applied, constraints applied?
  • What space are they in?
  • That the final version is used as input when the flag is set.
672

Should be values_final for consistency, same for flag.

773–775

Even though auto-values didn't have comments, this could, 1-2 lines explaining why it's needed.

This revision now requires changes to proceed.Fri, Aug 2, 5:33 AM
Germano Cavalcante (mano-wii) marked 3 inline comments as done.Fri, Aug 2, 5:58 AM
Germano Cavalcante (mano-wii) updated this revision to Diff 16785.
  • Comments and rename value_final to values_final.
This revision is now accepted and ready to land.Fri, Aug 2, 6:11 AM
  • Improve t->values_final description
  • imputed -> input