Page MenuHome

DrawManager: Crash Face Selection
AbandonedPublic

Authored by Jeroen Bakker (jbakker) on Jul 10 2019, 11:07 AM.

Details

Summary

Init the scene of the draw context when selecting. When using face dot selection on
when the subsurf modifier is active on the cage, the scene needs to be
valid. It is read from the context in the
DRW_mesh_batch_cache_create_requested and used in the isDisabled
method of the SubSurfModifier.

Diff Detail

Repository
rB Blender
Branch
face_selection_crash (branched from master)
Build Status
Buildable 4010
Build 4010: arc lint + arc unit

Event Timeline

Let's get some extra eyes on these last minute fixes.

This revision is now accepted and ready to land.Jul 10 2019, 11:57 AM

Looks fine, but i am not really an expert in the area, so can not foresee all consequences of such state change.

oops didn't meant that! sorry! you can commit that.