Page MenuHome

Move sequence, movieclip and text editor progressbars to status bar
ClosedPublic

Authored by Richard Antalik (ISS) on Jul 10 2019, 5:17 PM.

Diff Detail

Repository
rB Blender

Event Timeline

  • - fix asignment of owner
Richard Antalik (ISS) retitled this revision from Fix some progressbars are not shown to Move sequence, movieclip and text editor progressbars to status bar.Mon, Jul 29, 1:00 AM
Richard Antalik (ISS) edited the summary of this revision. (Show Details)

Can confirm it is working(on Win 10) for the Sequencer and the Movie Clip Editor.

Sergey Sharybin (sergey) requested changes to this revision.Mon, Jul 29, 12:47 PM

It seems that for movie clip this change doesn't move progress, but also shows it in the status bar, making it so progress is displayed in both clip editor's header and status bar. I don't think this is a great redundancy.

Also think if the progress is to be always displayed in the status bar, do we still need an owner parameter to WM_jobs_get() ?

There are unused variables warnings induced by this change:
tracking_ops_solve.c:194:12: warning: unused variable ‘sa’ [-Wunused-variable]
tracking_ops_track.c:291:12: warning: unused variable ‘sa’ [-Wunused-variable]

This revision now requires changes to proceed.Mon, Jul 29, 12:47 PM
  • fix unused vars
  • remove jobs template from clip editor

Also think if the progress is to be always displayed in the status bar, do we still need an owner parameter to WM_jobs_get() ?

Technically no, but some editors may rely on owner when they build up queue(context may be part of jobs customdata, not queue element itself)?
I can go through all callees to check, there are not so many.

Looks good, even if potentially code can be simplified further with removal of owner.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.