Page MenuHome

Fix compositor ignoring mask parenting
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jul 15 2019, 2:04 PM.

Details

Summary

There are two aspects to the problem:

  • Dependency graph update for compositor preview was missing updates flush.

    Apparently, update for new frame style of update will take care of flushing, but not the update tagged style of update.

    This goes to a legacy dependency graph and is to be changed at some point, but not so close to the release.
  • Movie clips were missing from the compositor dependency graph.

This fixes part of T66519.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Jul 15 2019, 4:52 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/depsgraph/intern/builder/deg_builder_relations.cc
2342–2344

Should this be ID_MSK -> ID_MC and mask_id -> parent->id?

Not sure how else a movie clip is used here.

This revision now requires changes to proceed.Jul 15 2019, 4:52 PM

Fix wrong parent relation.

Good catch, not sure what i was thinking about :(

This revision is now accepted and ready to land.Jul 15 2019, 5:11 PM
This revision was automatically updated to reflect the committed changes.