Page MenuHome

Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert
ClosedPublic

Authored by Gaia Clary (gaiaclary) on Jul 15 2019, 5:14 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Updating D5262: Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert

Roughness is not the same as shininess. The exact mapping depends on the BSDF and is probably hard to figure out.

But I would expect it to be closer to roughness = 1 - shininess. That is the lower the roughness, the shinier the material is.

Collada exporter only supports export of Lambert Shaders.
But Shininess is not supported with Lambert

Collada Importer adds illegal values of -1
for roughness and reflectivity when these
parameters are not defined in the imported collada data

Brecht Van Lommel (brecht) requested changes to this revision.Jul 15 2019, 6:50 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/collada/Materials.cpp
134–138

Metallic and Roughness are values in the 0..1 range. Assigning them only if the value is negative makes no sense to me?

This revision now requires changes to proceed.Jul 15 2019, 6:50 PM
Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert

Collada Importer adds illegal values of -1
for roughness and reflectivity when these
parameters are not defined in the imported collada data
Gaia Clary (gaiaclary) marked an inline comment as done.Jul 15 2019, 8:33 PM
Gaia Clary (gaiaclary) updated this revision to Diff 16415.

Postponed support for import of shininess to a later release (Blender 2.81)

Looks ok to commit now.

This revision is now accepted and ready to land.Jul 16 2019, 12:05 PM