Page MenuHome

Fix T65717: Alembic (camera - also mesh) import scale issue
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Jul 18 2019, 3:41 PM.

Details

Summary

Fix for T65717. The w-component of the translation column of the scaled matrix wasn't set to 1.0, which, apart from being incorrect, caused drawing problems.

Not a critical fix, so won't be part of 2.80.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Jul 26 2019, 3:14 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/alembic/intern/abc_object.cc
345–346

This is quite odd, making a non-affine transform for this purpose.

Just switching the order of operations should achieve the same:

float scale_mat[4][4];
scale_m4_fl(scale_mat, scale);
mul_m4_m4m4(r_mat, scale_mat, r_mat);
This revision now requires changes to proceed.Jul 26 2019, 3:14 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 16624.
  • Fixed matrix multiplication
Sybren A. Stüvel (sybren) marked an inline comment as done.Jul 26 2019, 4:50 PM
Sybren A. Stüvel (sybren) added inline comments.
source/blender/alembic/intern/abc_object.cc
345–346

thanks

This revision is now accepted and ready to land.Jul 26 2019, 5:28 PM