Page MenuHome

Fix T67221: Auto-offset in VSE doesn't refresh audio
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jul 19 2019, 3:05 PM.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Jul 19 2019, 3:25 PM

Still waiting for @Sergey Sharybin (sergey)' s green light, note that I'll be away next week, so if this is good to commit for 2.80, just do it (I wont be online to do this...)

Not sure why is it so deep in hierarchy. Would imagine to do it once at the end of the function.

Not sure why is it so deep in hierarchy. Would imagine to do it once at the end of the function.

You are right, I haven't looked at this in that detail.
I am not sure if it make sense to put tag at the end of function for all cases or if it should be done only if transformation is not cancelled. Considering, that overhead shouldn't be significant and we could avoid some edge cases...

This transform system is quite branched and hard to follow for me...

moved DEG update to end of freeSeqData() since all calls to BKE_sequence_base_shuffle_XXX / BKE_sequence_calc seem to benefit from it